<div class="gmail_quote">On Mon, Jun 27, 2011 at 22:04, Kirill A. Korinskiy <span dir="ltr"><<a href="mailto:catap@catap.ru">catap@catap.ru</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;">
<div class="gmail_quote"><div class="im">On Mon, Jun 27, 2011 at 21:06, Maxim Dounin <span dir="ltr"><<a href="mailto:mdounin@mdounin.ru" target="_blank">mdounin@mdounin.ru</a>></span> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div class="im">
# HG changeset patch<br>
# User Maxim Dounin <<a href="mailto:mdounin@mdounin.ru" target="_blank">mdounin@mdounin.ru</a>><br>
# Date 1309178032 -14400<br>
# Node ID b857d44e9644325dec7d63b8561ae3b4dfa16150<br>
# Parent 1c167244d2fdb064c159012c50a7ae3fd1ed254a<br>
Cache: fix another "stalled cache updating" alert.<br></div><div class="im">@@ -2991,16 +2982,19 @@ ngx_http_upstream_finalize_request(ngx_h<br>
<br></div></blockquote><div class="im"><div><br></div><div>[..]</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
#if (NGX_HTTP_CACHE)<br>
<br>
- if (u->cacheable && r->cache) {<br>
- time_t valid;<br>
-<br>
- if (rc == NGX_HTTP_BAD_GATEWAY || rc == NGX_HTTP_GATEWAY_TIME_OUT) {<br>
-<br>
- valid = ngx_http_file_cache_valid(u->conf->cache_valid, rc);<br>
-<br>
- if (valid) {<br>
- r->cache->valid_sec = ngx_time() + valid;<br>
- r->cache->error = rc;<br>
+ if (r->cache) {<br>
+<br>
+ if (u->cacheable) {<br>
+ time_t valid;<br>
+<br>
+ if (rc == NGX_HTTP_BAD_GATEWAY || rc == NGX_HTTP_GATEWAY_TIME_OUT) {<br>
+<br>
+ valid = ngx_http_file_cache_valid(u->conf->cache_valid, rc);<br>
+<br>
+ if (valid) {<br>
+ r->cache->valid_sec = ngx_time() + valid;<br>
+ r->cache->error = rc;<br>
+ }<br>
}<br>
}<br></blockquote><div><br></div></div><div>this a broken patch. I see another code at <a href="http://mdounin.ru/hg/nginx-vendor-current/file/1c167244d2fd/src/http/ngx_http_upstream.c#l2991" target="_blank">http://mdounin.ru/hg/nginx-vendor-current/file/1c167244d2fd/src/http/ngx_http_upstream.c#l2991</a></div>
</div>
</blockquote></div><br>nope, it's my mind is broken. Sorry.<br clear="all"><br>-- <br><div>wbr, Kirill</div><br>