<div class="gmail_quote">On Mon, Jun 27, 2011 at 21:06, Maxim Dounin <span dir="ltr">&lt;<a href="mailto:mdounin@mdounin.ru">mdounin@mdounin.ru</a>&gt;</span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;">
# HG changeset patch<br>
# User Maxim Dounin &lt;<a href="mailto:mdounin@mdounin.ru">mdounin@mdounin.ru</a>&gt;<br>
# Date 1309178032 -14400<br>
# Node ID b857d44e9644325dec7d63b8561ae3b4dfa16150<br>
# Parent  1c167244d2fdb064c159012c50a7ae3fd1ed254a<br>
Cache: fix another &quot;stalled cache updating&quot; alert.<br>@@ -2991,16 +2982,19 @@ ngx_http_upstream_finalize_request(ngx_h<br>
<br></blockquote><div><br></div><div>[..]</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;">
 #if (NGX_HTTP_CACHE)<br>
<br>
-    if (u-&gt;cacheable &amp;&amp; r-&gt;cache) {<br>
-        time_t  valid;<br>
-<br>
-        if (rc == NGX_HTTP_BAD_GATEWAY || rc == NGX_HTTP_GATEWAY_TIME_OUT) {<br>
-<br>
-            valid = ngx_http_file_cache_valid(u-&gt;conf-&gt;cache_valid, rc);<br>
-<br>
-            if (valid) {<br>
-                r-&gt;cache-&gt;valid_sec = ngx_time() + valid;<br>
-                r-&gt;cache-&gt;error = rc;<br>
+    if (r-&gt;cache) {<br>
+<br>
+        if (u-&gt;cacheable) {<br>
+            time_t  valid;<br>
+<br>
+            if (rc == NGX_HTTP_BAD_GATEWAY || rc == NGX_HTTP_GATEWAY_TIME_OUT) {<br>
+<br>
+                valid = ngx_http_file_cache_valid(u-&gt;conf-&gt;cache_valid, rc);<br>
+<br>
+                if (valid) {<br>
+                    r-&gt;cache-&gt;valid_sec = ngx_time() + valid;<br>
+                    r-&gt;cache-&gt;error = rc;<br>
+                }<br>
             }<br>
         }<br></blockquote><div><br></div><div>this a broken patch.  I see another code at <a href="http://mdounin.ru/hg/nginx-vendor-current/file/1c167244d2fd/src/http/ngx_http_upstream.c#l2991">http://mdounin.ru/hg/nginx-vendor-current/file/1c167244d2fd/src/http/ngx_http_upstream.c#l2991</a></div>
</div><br>-- <br><div>wbr, Kirill</div><br>